Fixes issues due to serverspec upgrade #146
Merged
underscorgan merged 1 commit intopuppetlabs:masterfrom Feb 9, 2015
Merged
Conversation
cyberious
force-pushed
the
SpecinfraUpgrade
branch
from
b74cb00 to
5d4685c
Compare
Contributor
There was a problem hiding this comment.
Did you intend to leave pry in here?
…ontain method for files
cyberious
force-pushed
the
SpecinfraUpgrade
branch
from
5d4685c to
8e2689b
Compare
Contributor
There was a problem hiding this comment.
Did the serverspec update fix this on solaris 10?
Contributor
Author
There was a problem hiding this comment.
yes, it works, I have tested it against solaris 10, it was the grep that was broken, its(:content) does not use the multiline grep so with a regex it matches.
Contributor
Author
There was a problem hiding this comment.
should contain still uses the specinfra matcher, however the serverspec its(:content) would use the https://github.com/serverspec/serverspec/blob/5b7e90f259305726527253744f7a0feb3de1cae4/lib/serverspec/type/file.rb#L97-L102 and read as a string and then use rspec match regex to match the multiline string.
underscorgan
pushed a commit
that referenced
this pull request
Feb 9, 2015
Fixes issues due to serverspec upgrade
cegeka-jenkins
pushed a commit
to cegeka/puppet-inifile
that referenced
this pull request
Oct 23, 2017
Fixes issues due to serverspec upgrade
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and usage of obsolete should contain method for files